fix: prevent dynamic field overwrite when building dynamic row #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rakuzen25 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @rakuzen25! It looks like this is your first PR to milvus-io/milvus-sdk-node 🎉 |
…mic row see milvus-io#399 Signed-off-by: Frank <[email protected]>
rakuzen25
force-pushed
the
fix/prevent-dynamic-field-overwrite
branch
from
6bac264 to
0d14522
Compare
rakuzen25
commented
Dec 26, 2024
Comment on lines
+474
to
+480
| // do this last to prevent any non-deterministic behavior with loop order | ||
| if (originRow[dynamicFieldName]) { | ||
| // extend the dynamic field object with the input dynamic field object | ||
| row[dynamicFieldName] = row[dynamicFieldName] || ({} as JSON); | ||
| Object.assign(row[dynamicFieldName] as JSON, originRow[dynamicFieldName]); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not sure if this is the intended behaviour when the input data is something like:
{
$meta: {
key2: "value22",
},
key1: "value1",
key2: "value2",
}where key2 is a dynamic field not specified in the schema.
|
Thank you for the contribution, I have a better solution here. can you help on review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #399 for context
This should fix the non-deterministic behaviour of dynamic fields; however, the behaviour when the user provides a non-empty dynamic field should be discussed.